Skip to content

Commit

Permalink
net: davinci_mdio: Fix typo mistake in calling runtime-pm api
Browse files Browse the repository at this point in the history
By mistake (most likely a copy-paste), instead of pm_runtime_get_sync()
api, driver is calling pm_runtime_put_sync() api in resume callback
function. The bug was introduced by commit id (ae2c07aaf74:
davinci_mdio: runtime PM support).

Now, the reason why it didn't impact functionality is, the patch has
been tested on AM335x-EVM and BeagleBone platform while submitting;
and in case of AM335x the MDIO driver doesn't control the module
enable/disable part, which is handled by CPSW driver.

Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vaibhav Hiremath authored and David S. Miller committed Nov 15, 2012
1 parent b092d92 commit d1df50f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/ti/davinci_mdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ static int davinci_mdio_resume(struct device *dev)
u32 ctrl;

spin_lock(&data->lock);
pm_runtime_put_sync(data->dev);
pm_runtime_get_sync(data->dev);

/* restart the scan state machine */
ctrl = __raw_readl(&data->regs->control);
Expand Down

0 comments on commit d1df50f

Please sign in to comment.