Skip to content

Commit

Permalink
ipv6: additional ref count for hash list unnecessary
Browse files Browse the repository at this point in the history
Since an address in hash list has to already have a ref count,
no additional ref count is needed.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
stephen hemminger authored and David S. Miller committed Apr 13, 2010
1 parent 27bdb2a commit d1f84c6
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions net/ipv6/addrconf.c
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,6 @@ ipv6_add_addr(struct inet6_dev *idev, const struct in6_addr *addr, int pfxlen,
hash = ipv6_addr_hash(addr);

hlist_add_head_rcu(&ifa->addr_lst, &inet6_addr_lst[hash]);
in6_ifa_hold(ifa);
spin_unlock(&addrconf_hash_lock);

write_lock(&idev->lock);
Expand Down Expand Up @@ -724,7 +723,6 @@ static void ipv6_del_addr(struct inet6_ifaddr *ifp)

spin_lock_bh(&addrconf_hash_lock);
hlist_del_init_rcu(&ifp->addr_lst);
__in6_ifa_put(ifp);
spin_unlock_bh(&addrconf_hash_lock);

write_lock_bh(&idev->lock);
Expand Down Expand Up @@ -2713,7 +2711,6 @@ static int addrconf_ifdown(struct net_device *dev, int how)
/* clear hash table */
spin_lock_bh(&addrconf_hash_lock);
hlist_del_init_rcu(&ifa->addr_lst);
__in6_ifa_put(ifa);
spin_unlock_bh(&addrconf_hash_lock);
}

Expand Down

0 comments on commit d1f84c6

Please sign in to comment.