Skip to content

Commit

Permalink
V4L/DVB (3123b): syncs V4L subsystem tree with kernel
Browse files Browse the repository at this point in the history
- This patch makes kernel in sync with v4l subsystem tree.
- some lines reordered to be sync.
- some reduntant codes removed.

Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
  • Loading branch information
Mauro Carvalho Chehab committed Jan 9, 2006
1 parent b060c25 commit d21838d
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 26 deletions.
3 changes: 1 addition & 2 deletions drivers/media/video/cx88/cx88-blackbird.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
#include "cx88.h"

MODULE_DESCRIPTION("driver for cx2388x/cx23416 based mpeg encoder cards");
MODULE_AUTHOR("Jelle Foks <jelle@foks.8m.com>");
MODULE_AUTHOR("Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]");
MODULE_AUTHOR("Jelle Foks <jelle@foks.8m.com>, Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]");
MODULE_LICENSE("GPL");

static unsigned int mpegbufs = 32;
Expand Down
3 changes: 1 addition & 2 deletions drivers/media/video/cx88/cx88-input.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@
#include <linux/module.h>
#include <linux/moduleparam.h>

#include <media/ir-common.h>

#include "cx88.h"
#include <media/ir-common.h>

/* ---------------------------------------------------------------------- */

Expand Down
6 changes: 3 additions & 3 deletions drivers/media/video/em28xx/em28xx-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

/* #define ENABLE_DEBUG_ISOC_FRAMES */

static unsigned int core_debug;
static unsigned int core_debug = 0;
module_param(core_debug,int,0644);
MODULE_PARM_DESC(core_debug,"enable debug messages [core]");

Expand All @@ -41,7 +41,7 @@ MODULE_PARM_DESC(core_debug,"enable debug messages [core]");
printk(KERN_INFO "%s %s :"fmt, \
dev->name, __FUNCTION__ , ##arg); } while (0)

static unsigned int reg_debug;
static unsigned int reg_debug = 0;
module_param(reg_debug,int,0644);
MODULE_PARM_DESC(reg_debug,"enable debug messages [URB reg]");

Expand All @@ -50,7 +50,7 @@ MODULE_PARM_DESC(reg_debug,"enable debug messages [URB reg]");
printk(KERN_INFO "%s %s :"fmt, \
dev->name, __FUNCTION__ , ##arg); } while (0)

static unsigned int isoc_debug;
static unsigned int isoc_debug = 0;
module_param(isoc_debug,int,0644);
MODULE_PARM_DESC(isoc_debug,"enable debug messages [isoc transfers]");

Expand Down
8 changes: 3 additions & 5 deletions drivers/media/video/ir-kbd-gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@
#include <linux/input.h>
#include <linux/pci.h>

#include <media/ir-common.h>

#include "bttv.h"
#include <media/ir-common.h>

/* ---------------------------------------------------------------------- */

Expand Down Expand Up @@ -672,6 +671,8 @@ static int ir_probe(struct device *dev)
snprintf(ir->phys, sizeof(ir->phys), "pci-%s/ir0",
pci_name(sub->core->pci));

ir->input = input_dev;
ir->sub = sub;
ir_input_init(input_dev, &ir->ir, ir_type, ir_codes);
input_dev->name = ir->name;
input_dev->phys = ir->phys;
Expand All @@ -686,9 +687,6 @@ static int ir_probe(struct device *dev)
}
input_dev->cdev.dev = &sub->core->pci->dev;

ir->input = input_dev;
ir->sub = sub;

if (ir->polling) {
INIT_WORK(&ir->work, ir_work, ir);
init_timer(&ir->timer);
Expand Down
16 changes: 10 additions & 6 deletions drivers/media/video/ir-kbd-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,18 +304,20 @@ static int ir_attach(struct i2c_adapter *adap, int addr,
ir = kzalloc(sizeof(struct IR_i2c),GFP_KERNEL);
input_dev = input_allocate_device();
if (!ir || !input_dev) {
kfree(ir);
input_free_device(input_dev);
kfree(ir);
return -ENOMEM;
}
memset(ir,0,sizeof(*ir));

ir->c = client_template;
ir->input = input_dev;

i2c_set_clientdata(&ir->c, ir);
ir->c.adapter = adap;
ir->c.addr = addr;

i2c_set_clientdata(&ir->c, ir);

switch(addr) {
case 0x64:
name = "Pixelview";
Expand Down Expand Up @@ -378,13 +380,15 @@ static int ir_attach(struct i2c_adapter *adap, int addr,
ir->c.dev.bus_id);

/* init + register input device */
ir_input_init(input_dev, &ir->ir, ir_type, ir_codes);
input_dev->id.bustype = BUS_I2C;
input_dev->name = ir->c.name;
input_dev->phys = ir->phys;
ir_input_init(input_dev,&ir->ir,ir_type,ir->ir_codes);
input_dev->id.bustype = BUS_I2C;
input_dev->name = ir->c.name;
input_dev->phys = ir->phys;

/* register event device */
input_register_device(ir->input);
printk(DEVNAME ": %s detected at %s [%s]\n",
ir->input->name,ir->input->phys,adap->name);

/* start polling via eventd */
INIT_WORK(&ir->work, ir_work, ir);
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/saa7134/saa7134-alsa.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
*
*/

#include <sound/driver.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/time.h>
#include <linux/wait.h>
#include <linux/moduleparam.h>
#include <linux/module.h>
#include <sound/driver.h>
#include <sound/core.h>
#include <sound/control.h>
#include <sound/pcm.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/saa7134/saa7134-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ static int pending_call(struct notifier_block *self, unsigned long state,
return NOTIFY_DONE;
}

static int pending_registered;
static int pending_registered=0;
static struct notifier_block pending_notifier = {
.notifier_call = pending_call,
};
Expand Down
7 changes: 3 additions & 4 deletions drivers/media/video/saa7134/saa7134.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
#include <media/ir-common.h>
#include <media/ir-kbd-i2c.h>
#include <media/video-buf.h>
#include <sound/driver.h>
#include <sound/core.h>
#include <sound/pcm.h>
#include <media/video-buf-dvb.h>

#ifndef TRUE
Expand All @@ -47,10 +50,6 @@
#endif
#define UNSET (-1U)

#include <sound/driver.h>
#include <sound/core.h>
#include <sound/pcm.h>

/* ----------------------------------------------------------- */
/* enums */

Expand Down
6 changes: 4 additions & 2 deletions drivers/media/video/videodev.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ static void video_release(struct class_device *cd)
{
struct video_device *vfd = container_of(cd, struct video_device, class_dev);

#if 1 /* needed until all drivers are fixed */
#if 1
/* needed until all drivers are fixed */
if (!vfd->release)
return;
#endif
Expand Down Expand Up @@ -344,7 +345,8 @@ int video_register_device(struct video_device *vfd, int type, int nr)
class_device_create_file(&vfd->class_dev,
&class_device_attr_name);

#if 1 /* needed until all drivers are fixed */
#if 1
/* needed until all drivers are fixed */
if (!vfd->release)
printk(KERN_WARNING "videodev: \"%s\" has no release callback. "
"Please fix your driver for proper sysfs support, see "
Expand Down

0 comments on commit d21838d

Please sign in to comment.