Skip to content

Commit

Permalink
KVM: PIT: unregister kvm irq notifier if fail to create pit
Browse files Browse the repository at this point in the history
If fail to create pit, we should unregister kvm irq notifier
which register in kvm_create_pit().

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Acked-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
Wei Yongjun authored and Marcelo Tosatti committed Mar 1, 2010
1 parent a19a6d1 commit d225f53
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions arch/x86/kvm/i8254.c
Original file line number Diff line number Diff line change
Expand Up @@ -663,8 +663,9 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
kvm_io_bus_unregister_dev(kvm, KVM_PIO_BUS, &pit->dev);

fail:
if (pit->irq_source_id >= 0)
kvm_free_irq_source_id(kvm, pit->irq_source_id);
kvm_unregister_irq_mask_notifier(kvm, 0, &pit->mask_notifier);
kvm_unregister_irq_ack_notifier(kvm, &pit_state->irq_ack_notifier);
kvm_free_irq_source_id(kvm, pit->irq_source_id);

kfree(pit);
return NULL;
Expand Down

0 comments on commit d225f53

Please sign in to comment.