---

yaml --- r: 23527 b: refs/heads/master c: 9a56c21 h: refs/heads/master i: 23525: ad4b3e0 23523: 0f0fe44 23519: 85c3b4d v: v3
git-mirror · Mar 25, 2006 · d22a467 · d22a467
1 parent e5f94b1
commit d22a467
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: b500531e6f5f234ed267bd7060ee06d144faf0ca
+refs/heads/master: 9a56c213929d83139fd1e12727e1037d71b519f8
diff --git a/trunk/fs/open.c b/trunk/fs/open.c
@@ -890,6 +890,10 @@ EXPORT_SYMBOL(filp_open);
  * a fully instantiated struct file to the caller.
  * This function is meant to be called from within a filesystem's
  * lookup method.
+ * Beware of calling it for non-regular files! Those ->open methods might block
+ * (e.g. in fifo_open), leaving you with parent locked (and in case of fifo,
+ * leading to a deadlock, as nobody can open that fifo anymore, because
+ * another process to open fifo will block on locked parent when doing lookup).
  * Note that in case of error, nd->intent.open.file is destroyed, but the
  * path information remains valid.
  * If the open callback is set to NULL, then the standard f_op->open()