Skip to content

Commit

Permalink
[POWERPC] Update device tree binding for mpc5200 gpt
Browse files Browse the repository at this point in the history 
Add 'fsl,' prefix to 'compatible' property for gpt nodes.
Add 'fsl,' prefix to empty, GPT0 specific 'has-wdt' property.
The fsl, prefix is being added to better match the convention of prefixing
manufacturer specific properties and values with the vendors name.

Signed-off-by: Marian Balakowicz <m8@semihalf.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Marian Balakowicz authored and Grant Likely committed Oct 21, 2007
1 parent c5c01c9 commit d24bc31
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 36 deletions.
4 changes: 2 additions & 2 deletions Documentation/powerpc/mpc52xx-device-tree-bindings.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ bestcomm@<addr> dma-controller mpc5200-bestcomm 5200 pic also requires
Recommended soc5200 child nodes; populate as needed for your board
name device_type compatible Description
---- ----------- ---------- -----------
gpt@<addr> gpt mpc5200-gpt General purpose timers
gpt@<addr> gpt fsl,mpc5200-gpt General purpose timers
rtc@<addr> rtc mpc5200-rtc Real time clock
mscan@<addr> mscan mpc5200-mscan CAN bus controller
pci@<addr> pci mpc5200-pci PCI bridge
Expand Down Expand Up @@ -213,7 +213,7 @@ cell-index int When multiple devices are present, is the
5) General Purpose Timer nodes (child of soc5200 node)
On the mpc5200 and 5200b, GPT0 has a watchdog timer function. If the board
design supports the internal wdt, then the device node for GPT0 should
include the empty property 'has-wdt'.
include the empty property 'fsl,has-wdt'.

6) PSC nodes (child of soc5200 node)
PSC nodes can define the optional 'port-number' property to force assignment
Expand Down
26 changes: 9 additions & 17 deletions arch/powerpc/boot/dts/lite5200.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,72 +70,64 @@
};

gpt@600 { // General Purpose Timer
compatible = "mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200-gpt";
cell-index = <0>;
reg = <600 10>;
interrupts = <1 9 0>;
interrupt-parent = <&mpc5200_pic>;
has-wdt;
fsl,has-wdt;
};

gpt@610 { // General Purpose Timer
compatible = "mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200-gpt";
cell-index = <1>;
reg = <610 10>;
interrupts = <1 a 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@620 { // General Purpose Timer
compatible = "mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200-gpt";
cell-index = <2>;
reg = <620 10>;
interrupts = <1 b 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@630 { // General Purpose Timer
compatible = "mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200-gpt";
cell-index = <3>;
reg = <630 10>;
interrupts = <1 c 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@640 { // General Purpose Timer
compatible = "mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200-gpt";
cell-index = <4>;
reg = <640 10>;
interrupts = <1 d 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@650 { // General Purpose Timer
compatible = "mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200-gpt";
cell-index = <5>;
reg = <650 10>;
interrupts = <1 e 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@660 { // General Purpose Timer
compatible = "mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200-gpt";
cell-index = <6>;
reg = <660 10>;
interrupts = <1 f 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@670 { // General Purpose Timer
compatible = "mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200-gpt";
cell-index = <7>;
reg = <670 10>;
interrupts = <1 10 0>;
Expand Down
26 changes: 9 additions & 17 deletions arch/powerpc/boot/dts/lite5200b.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,72 +70,64 @@
};

gpt@600 { // General Purpose Timer
compatible = "mpc5200b-gpt","mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
cell-index = <0>;
reg = <600 10>;
interrupts = <1 9 0>;
interrupt-parent = <&mpc5200_pic>;
has-wdt;
fsl,has-wdt;
};

gpt@610 { // General Purpose Timer
compatible = "mpc5200b-gpt","mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
cell-index = <1>;
reg = <610 10>;
interrupts = <1 a 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@620 { // General Purpose Timer
compatible = "mpc5200b-gpt","mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
cell-index = <2>;
reg = <620 10>;
interrupts = <1 b 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@630 { // General Purpose Timer
compatible = "mpc5200b-gpt","mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
cell-index = <3>;
reg = <630 10>;
interrupts = <1 c 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@640 { // General Purpose Timer
compatible = "mpc5200b-gpt","mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
cell-index = <4>;
reg = <640 10>;
interrupts = <1 d 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@650 { // General Purpose Timer
compatible = "mpc5200b-gpt","mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
cell-index = <5>;
reg = <650 10>;
interrupts = <1 e 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@660 { // General Purpose Timer
compatible = "mpc5200b-gpt","mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
cell-index = <6>;
reg = <660 10>;
interrupts = <1 f 0>;
interrupt-parent = <&mpc5200_pic>;
};

gpt@670 { // General Purpose Timer
compatible = "mpc5200b-gpt","mpc5200-gpt";
device_type = "gpt";
compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
cell-index = <7>;
reg = <670 10>;
interrupts = <1 10 0>;
Expand Down
3 changes: 3 additions & 0 deletions drivers/watchdog/mpc5200_wdt.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ static int mpc5200_wdt_probe(struct of_device *op, const struct of_device_id *ma
int size;

has_wdt = of_get_property(op->node, "has-wdt", NULL);
if (!has_wdt)
has_wdt = of_get_property(op->node, "fsl,has-wdt", NULL);
if (!has_wdt)
return -ENODEV;

Expand Down Expand Up @@ -254,6 +256,7 @@ static int mpc5200_wdt_shutdown(struct of_device *op)

static struct of_device_id mpc5200_wdt_match[] = {
{ .compatible = "mpc5200-gpt", },
{ .compatible = "fsl,mpc5200-gpt", },
{},
};
static struct of_platform_driver mpc5200_wdt_driver = {
Expand Down

0 comments on commit d24bc31

Please sign in to comment.