Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 245343
b: refs/heads/master
c: a144c6a
h: refs/heads/master
i:
  245341: f5fc4a2
  245339: 9c306ac
  245335: 64aab33
  245327: f592220
  245311: dd0ad0e
v: v3
  • Loading branch information
Rafael J. Wysocki committed May 17, 2011
1 parent bba7e07 commit d2583e1
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 1 deletion.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: e1866b33b1e89f077b7132daae3dfd9a594e9a1a
refs/heads/master: a144c6a6c924aa1da04dd77fb84b89927354fdff
5 changes: 5 additions & 0 deletions trunk/drivers/base/firmware_class.c
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,11 @@ static int _request_firmware(const struct firmware **firmware_p,
if (!firmware_p)
return -EINVAL;

if (WARN_ON(usermodehelper_is_disabled())) {
dev_err(device, "firmware: %s will not be loaded\n", name);
return -EBUSY;
}

*firmware_p = firmware = kzalloc(sizeof(*firmware), GFP_KERNEL);
if (!firmware) {
dev_err(device, "%s: kmalloc(struct firmware) failed\n",
Expand Down
5 changes: 5 additions & 0 deletions trunk/include/linux/kmod.h
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,12 @@ call_usermodehelper(char *path, char **argv, char **envp, enum umh_wait wait)

extern void usermodehelper_init(void);

#ifdef CONFIG_PM_SLEEP
extern int usermodehelper_disable(void);
extern void usermodehelper_enable(void);
extern bool usermodehelper_is_disabled(void);
#else
static inline bool usermodehelper_is_disabled(void) { return false; }
#endif

#endif /* __LINUX_KMOD_H__ */
9 changes: 9 additions & 0 deletions trunk/kernel/kmod.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,15 @@ void usermodehelper_enable(void)
usermodehelper_disabled = 0;
}

/**
* usermodehelper_is_disabled - check if new helpers are allowed to be started
*/
bool usermodehelper_is_disabled(void)
{
return usermodehelper_disabled;
}
EXPORT_SYMBOL_GPL(usermodehelper_is_disabled);

static void helper_lock(void)
{
atomic_inc(&running_helpers);
Expand Down

0 comments on commit d2583e1

Please sign in to comment.