Skip to content

Commit

Permalink
x86, MCE, AMD: Hide interrupt_enable sysfs node
Browse files Browse the repository at this point in the history
Depending on whether the box supports the APIC LVT interrupt for
thresholding, we want to show the 'interrupt_enable' sysfs node or not.
Make that the case by adding it to the default sysfs attributes only if
it is supported.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
  • Loading branch information
Borislav Petkov committed Apr 30, 2012
1 parent f227d43 commit d26ecc4
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions arch/x86/kernel/cpu/mcheck/mce_amd.c
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,10 @@ RW_ATTR(threshold_limit);
RW_ATTR(error_count);

static struct attribute *default_attrs[] = {
&interrupt_enable.attr,
&threshold_limit.attr,
&error_count.attr,
NULL
NULL, /* possibly interrupt_enable if supported, see below */
NULL,
};

#define to_block(k) container_of(k, struct threshold_block, kobj)
Expand Down Expand Up @@ -501,6 +501,11 @@ static __cpuinit int allocate_threshold_blocks(unsigned int cpu,
b->interrupt_capable = lvt_interrupt_supported(bank, high);
b->threshold_limit = THRESHOLD_MAX;

if (b->interrupt_capable)
threshold_ktype.default_attrs[2] = &interrupt_enable.attr;
else
threshold_ktype.default_attrs[2] = NULL;

INIT_LIST_HEAD(&b->miscj);

if (per_cpu(threshold_banks, cpu)[bank]->blocks) {
Expand Down

0 comments on commit d26ecc4

Please sign in to comment.