Skip to content

Commit

Permalink
target: cleanup transport_execute_tasks()
Browse files Browse the repository at this point in the history
The function is effectively void and doesn't need any goto logic.

Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Jörn Engel authored and Nicholas Bellinger committed May 11, 2012
1 parent 11e764b commit d28d96d
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions drivers/target/target_core_transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -1970,7 +1970,7 @@ static inline int transport_execute_task_attr(struct se_cmd *cmd)
* Called from fabric module context in transport_generic_new_cmd() and
* transport_generic_process_write()
*/
static int transport_execute_tasks(struct se_cmd *cmd)
static void transport_execute_tasks(struct se_cmd *cmd)
{
int add_tasks;
struct se_device *se_dev = cmd->se_dev;
Expand All @@ -1984,16 +1984,12 @@ static int transport_execute_tasks(struct se_cmd *cmd)
* attribute for the tasks of the received struct se_cmd CDB
*/
add_tasks = transport_execute_task_attr(cmd);
if (!add_tasks)
goto execute_tasks;

__transport_execute_tasks(se_dev, cmd);
return 0;
if (add_tasks) {
__transport_execute_tasks(se_dev, cmd);
return;
}
}

execute_tasks:
__transport_execute_tasks(se_dev, NULL);
return 0;
}

static int __transport_execute_tasks(struct se_device *dev, struct se_cmd *new_cmd)
Expand Down

0 comments on commit d28d96d

Please sign in to comment.