locks: convert an -EINVAL return to a BUG

There's no point trying to return an error in these cases, which all represent bugs in the callers. Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
git-mirror · Jul 18, 2007 · d2ab0b0 · d2ab0b0
1 parent 87250dd
commit d2ab0b0
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/fs/locks.c b/fs/locks.c
@@ -1348,9 +1348,7 @@ static int __setlease(struct file *filp, long arg, struct file_lock **flp)
 
 	time_out_leases(inode);
 
-	error = -EINVAL;
-	if (!flp || !(*flp) || !(*flp)->fl_lmops || !(*flp)->fl_lmops->fl_break)
-		goto out;
+	BUG_ON(!(*flp)->fl_lmops->fl_break);
 
 	lease = *flp;