Skip to content

Commit

Permalink
[PATCH] loopback: #ifdef the TSO code
Browse files Browse the repository at this point in the history
This patch #ifdefs the TSO code in the loopback driver.

Saves ~800 bytes of text on i386 and avoids a conditional in the fast path.

Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Chuck Ebbert authored and Jeff Garzik committed Jul 31, 2005
1 parent 2f76147 commit d2ae1d2
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/net/loopback.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ static DEFINE_PER_CPU(struct net_device_stats, loopback_stats);
* of largesending device modulo TCP checksum, which is ignored for loopback.
*/

#ifdef LOOPBACK_TSO
static void emulate_large_send_offload(struct sk_buff *skb)
{
struct iphdr *iph = skb->nh.iph;
Expand Down Expand Up @@ -119,6 +120,7 @@ static void emulate_large_send_offload(struct sk_buff *skb)

dev_kfree_skb(skb);
}
#endif /* LOOPBACK_TSO */

/*
* The higher levels take care of making this non-reentrant (it's
Expand All @@ -136,14 +138,15 @@ static int loopback_xmit(struct sk_buff *skb, struct net_device *dev)
skb->ip_summed = CHECKSUM_UNNECESSARY;
#endif

#ifdef LOOPBACK_TSO
if (skb_shinfo(skb)->tso_size) {
BUG_ON(skb->protocol != htons(ETH_P_IP));
BUG_ON(skb->nh.iph->protocol != IPPROTO_TCP);

emulate_large_send_offload(skb);
return 0;
}

#endif
dev->last_rx = jiffies;

lb_stats = &per_cpu(loopback_stats, get_cpu());
Expand Down Expand Up @@ -209,6 +212,9 @@ struct net_device loopback_dev = {
.rebuild_header = eth_rebuild_header,
.flags = IFF_LOOPBACK,
.features = NETIF_F_SG|NETIF_F_FRAGLIST
#ifdef LOOPBACK_TSO
|NETIF_F_TSO
#endif
|NETIF_F_NO_CSUM|NETIF_F_HIGHDMA
|NETIF_F_LLTX,
.ethtool_ops = &loopback_ethtool_ops,
Expand Down

0 comments on commit d2ae1d2

Please sign in to comment.