Skip to content

Commit

Permalink
x86: do not zap_low_mappings in __smp_prepare_cpus
Browse files Browse the repository at this point in the history
It was okay when cpus were cold booted before this point.
But with the new state machine, they will not have arrived to
the trampoline yet. zapping low mappings will have the bad effect
of breaking it completely after paging enablement

Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Glauber de Oliveira Costa authored and Ingo Molnar committed Apr 17, 2008
1 parent 802b813 commit d2bcbad
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions arch/x86/kernel/smpboot_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,6 @@ static void __cpuinit start_secondary(void *unused)
enable_NMI_through_LVT0();
enable_8259A_irq(0);
}
/*
* low-memory mappings have been cleared, flush them from
* the local TLBs too.
*/
local_flush_tlb();

/* This must be done before setting cpu_online_map */
set_cpu_sibling_map(raw_smp_processor_id());
Expand Down Expand Up @@ -714,8 +709,6 @@ static void __cpuinit __smp_prepare_cpu(int cpu)
schedule_work(&info.task);
wait_for_completion(&done);
}

zap_low_mappings();
}
#endif

Expand Down

0 comments on commit d2bcbad

Please sign in to comment.