Skip to content

Commit

Permalink
dmaengine: imx-sdma: fix bug in buffer descriptor initialization
Browse files Browse the repository at this point in the history
Currently while submitting scatterlists with more than one SG
entry the DMA buffer address from the first SG entry is inserted
into all initialized DMA buffer descriptors. This is due to the
typo in the for_each_sg() loop where the scatterlist pointer is
used for obtaining the DMA buffer address and _not_ the SG list
iterator.

As a result all received data will be written only into the first
DMA buffer while reading. While writing the data from the first
DMA buffer is send to the device multiple times. This caused
the filesystem destruction on the MMC card when using DMA in
mxcmmc driver.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
Anatolij Gustschin authored and Dan Williams committed Dec 4, 2010
1 parent a584bff commit d2f5c27
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/dma/imx-sdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ static struct dma_async_tx_descriptor *sdma_prep_slave_sg(
struct sdma_buffer_descriptor *bd = &sdmac->bd[i];
int param;

bd->buffer_addr = sgl->dma_address;
bd->buffer_addr = sg->dma_address;

count = sg->length;

Expand Down

0 comments on commit d2f5c27

Please sign in to comment.