Skip to content

Commit

Permalink
V4L/DVB (11230): hdpvr: return immediately from hdpvr_poll if data is…
Browse files Browse the repository at this point in the history
… available

simplifies check for available data with hdpvr_get_next_buffer

Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Janne Grunau authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent a50ab29 commit d2ff3ec
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions drivers/media/video/hdpvr/hdpvr-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ static ssize_t hdpvr_read(struct file *file, char __user *buffer, size_t count,

static unsigned int hdpvr_poll(struct file *filp, poll_table *wait)
{
struct hdpvr_buffer *buf = NULL;
struct hdpvr_fh *fh = (struct hdpvr_fh *)filp->private_data;
struct hdpvr_device *dev = fh->dev;
unsigned int mask = 0;
Expand All @@ -499,19 +500,14 @@ static unsigned int hdpvr_poll(struct file *filp, poll_table *wait)
}
mutex_unlock(&dev->io_mutex);

poll_wait(filp, &dev->wait_data, wait);

mutex_lock(&dev->io_mutex);
if (!list_empty(&dev->rec_buff_list)) {

struct hdpvr_buffer *buf = list_entry(dev->rec_buff_list.next,
struct hdpvr_buffer,
buff_list);

if (buf->status == BUFSTAT_READY)
mask |= POLLIN | POLLRDNORM;
buf = hdpvr_get_next_buffer(dev);
/* only wait if no data is available */
if (!buf || buf->status != BUFSTAT_READY) {
poll_wait(filp, &dev->wait_data, wait);
buf = hdpvr_get_next_buffer(dev);
}
mutex_unlock(&dev->io_mutex);
if (buf && buf->status == BUFSTAT_READY)
mask |= POLLIN | POLLRDNORM;

return mask;
}
Expand Down

0 comments on commit d2ff3ec

Please sign in to comment.