Skip to content

Commit

Permalink
Bluetooth: hidp: fix information leak to userland
Browse files Browse the repository at this point in the history
Structure hidp_conninfo is copied to userland with version, product,
vendor and name fields unitialized if both session->input and session->hid
are NULL.  It leads to leaking of contents of kernel stack memory.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
  • Loading branch information
Vasiliy Kulikov authored and Gustavo F. Padovan committed Dec 1, 2010
1 parent 3185fbd commit d31dbf6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/bluetooth/hidp/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ static void __hidp_unlink_session(struct hidp_session *session)

static void __hidp_copy_session(struct hidp_session *session, struct hidp_conninfo *ci)
{
memset(ci, 0, sizeof(*ci));
bacpy(&ci->bdaddr, &session->bdaddr);

ci->flags = session->flags;
Expand All @@ -115,7 +116,6 @@ static void __hidp_copy_session(struct hidp_session *session, struct hidp_connin
ci->vendor = 0x0000;
ci->product = 0x0000;
ci->version = 0x0000;
memset(ci->name, 0, 128);

if (session->input) {
ci->vendor = session->input->id.vendor;
Expand Down

0 comments on commit d31dbf6

Please sign in to comment.