Skip to content

Commit

Permalink
staging: comedi: addi_apci_1516: remove devpriv->iobase usage
Browse files Browse the repository at this point in the history
The iobase address stored in devpriv->iobase is also stored in dev->iobase.
Use that instead.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Nov 13, 2012
1 parent 82c2bc7 commit d330b1d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
10 changes: 3 additions & 7 deletions drivers/staging/comedi/drivers/addi-data/hwdrv_apci1516.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,7 @@ static int apci1516_di_insn_bits(struct comedi_device *dev,
struct comedi_insn *insn,
unsigned int *data)
{
struct addi_private *devpriv = dev->private;

data[1] = inw(devpriv->iobase + APCI1516_DI_REG);
data[1] = inw(dev->iobase + APCI1516_DI_REG);

return insn->n;
}
Expand All @@ -87,17 +85,15 @@ static int apci1516_do_insn_bits(struct comedi_device *dev,
struct comedi_insn *insn,
unsigned int *data)
{

struct addi_private *devpriv = dev->private;
unsigned int mask = data[0];
unsigned int bits = data[1];

s->state = inw(devpriv->iobase + APCI1516_DO_REG);
s->state = inw(dev->iobase + APCI1516_DO_REG);
if (mask) {
s->state &= ~mask;
s->state |= (bits & mask);

outw(s->state, devpriv->iobase + APCI1516_DO_REG);
outw(s->state, dev->iobase + APCI1516_DO_REG);
}

data[1] = s->state;
Expand Down
3 changes: 1 addition & 2 deletions drivers/staging/comedi/drivers/addi_apci_1516.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ static int apci1516_reset(struct comedi_device *dev)
if (!this_board->i_Timer)
return 0;

outw(0x0, devpriv->iobase + APCI1516_DO_REG);
outw(0x0, dev->iobase + APCI1516_DO_REG);
outw(0x0, devpriv->i_IobaseAddon + APCI1516_WDOG_CTRL_REG);
outw(0x0, devpriv->i_IobaseAddon + APCI1516_WDOG_RELOAD_LSB_REG);
outw(0x0, devpriv->i_IobaseAddon + APCI1516_WDOG_RELOAD_MSB_REG);
Expand Down Expand Up @@ -85,7 +85,6 @@ static int __devinit apci1516_auto_attach(struct comedi_device *dev,
return ret;

dev->iobase = pci_resource_start(pcidev, 1);
devpriv->iobase = dev->iobase;
devpriv->i_IobaseAmcc = pci_resource_start(pcidev, 0);
devpriv->i_IobaseAddon = pci_resource_start(pcidev, 2);
devpriv->i_IobaseReserved = pci_resource_start(pcidev, 3);
Expand Down

0 comments on commit d330b1d

Please sign in to comment.