Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 58989
b: refs/heads/master
c: 330f7db
h: refs/heads/master
i:
  58987: 5aa5efa
v: v3
  • Loading branch information
Patrick McHardy authored and David S. Miller committed Jul 11, 2007
1 parent ad3dfe7 commit d336ab1
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 15 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: f205c5e0c28aa7e0fb6eaaa66e97928f9d9e6994
refs/heads/master: 330f7db5e578e1e298ba3a41748e5ea333a64a2b
3 changes: 1 addition & 2 deletions trunk/include/net/netfilter/nf_conntrack_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ nf_ct_invert_tuple(struct nf_conntrack_tuple *inverse,

/* Find a connection corresponding to a tuple. */
extern struct nf_conntrack_tuple_hash *
nf_conntrack_find_get(const struct nf_conntrack_tuple *tuple,
const struct nf_conn *ignored_conntrack);
nf_conntrack_find_get(const struct nf_conntrack_tuple *tuple);

extern int __nf_conntrack_confirm(struct sk_buff **pskb);

Expand Down
2 changes: 1 addition & 1 deletion trunk/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ getorigdst(struct sock *sk, int optval, void __user *user, int *len)
return -EINVAL;
}

h = nf_conntrack_find_get(&tuple, NULL);
h = nf_conntrack_find_get(&tuple);
if (h) {
struct sockaddr_in sin;
struct nf_conn *ct = nf_ct_tuplehash_to_ctrack(h);
Expand Down
4 changes: 2 additions & 2 deletions trunk/net/ipv4/netfilter/nf_conntrack_proto_icmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,13 @@ icmp_error_message(struct sk_buff *skb,

*ctinfo = IP_CT_RELATED;

h = nf_conntrack_find_get(&innertuple, NULL);
h = nf_conntrack_find_get(&innertuple);
if (!h) {
/* Locally generated ICMPs will match inverted if they
haven't been SNAT'ed yet */
/* FIXME: NAT code has to handle half-done double NAT --RR */
if (hooknum == NF_IP_LOCAL_OUT)
h = nf_conntrack_find_get(&origtuple, NULL);
h = nf_conntrack_find_get(&origtuple);

if (!h) {
DEBUGP("icmp_error_message: no match\n");
Expand Down
2 changes: 1 addition & 1 deletion trunk/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ icmpv6_error_message(struct sk_buff *skb,

*ctinfo = IP_CT_RELATED;

h = nf_conntrack_find_get(&intuple, NULL);
h = nf_conntrack_find_get(&intuple);
if (!h) {
DEBUGP("icmpv6_error: no match\n");
return -NF_ACCEPT;
Expand Down
7 changes: 3 additions & 4 deletions trunk/net/netfilter/nf_conntrack_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,12 @@ EXPORT_SYMBOL_GPL(__nf_conntrack_find);

/* Find a connection corresponding to a tuple. */
struct nf_conntrack_tuple_hash *
nf_conntrack_find_get(const struct nf_conntrack_tuple *tuple,
const struct nf_conn *ignored_conntrack)
nf_conntrack_find_get(const struct nf_conntrack_tuple *tuple)
{
struct nf_conntrack_tuple_hash *h;

read_lock_bh(&nf_conntrack_lock);
h = __nf_conntrack_find(tuple, ignored_conntrack);
h = __nf_conntrack_find(tuple, NULL);
if (h)
atomic_inc(&nf_ct_tuplehash_to_ctrack(h)->ct_general.use);
read_unlock_bh(&nf_conntrack_lock);
Expand Down Expand Up @@ -574,7 +573,7 @@ resolve_normal_ct(struct sk_buff *skb,
}

/* look for tuple match */
h = nf_conntrack_find_get(&tuple, NULL);
h = nf_conntrack_find_get(&tuple);
if (!h) {
h = init_conntrack(&tuple, l3proto, l4proto, skb, dataoff);
if (!h)
Expand Down
6 changes: 3 additions & 3 deletions trunk/net/netfilter/nf_conntrack_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ ctnetlink_del_conntrack(struct sock *ctnl, struct sk_buff *skb,
if (err < 0)
return err;

h = nf_conntrack_find_get(&tuple, NULL);
h = nf_conntrack_find_get(&tuple);
if (!h)
return -ENOENT;

Expand Down Expand Up @@ -744,7 +744,7 @@ ctnetlink_get_conntrack(struct sock *ctnl, struct sk_buff *skb,
if (err < 0)
return err;

h = nf_conntrack_find_get(&tuple, NULL);
h = nf_conntrack_find_get(&tuple);
if (!h)
return -ENOENT;

Expand Down Expand Up @@ -1426,7 +1426,7 @@ ctnetlink_create_expect(struct nfattr *cda[], u_int8_t u3)
return err;

/* Look for master conntrack of this expectation */
h = nf_conntrack_find_get(&master_tuple, NULL);
h = nf_conntrack_find_get(&master_tuple);
if (!h)
return -ENOENT;
ct = nf_ct_tuplehash_to_ctrack(h);
Expand Down
2 changes: 1 addition & 1 deletion trunk/net/netfilter/nf_conntrack_pptp.c
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ static int destroy_sibling_or_exp(const struct nf_conntrack_tuple *t)
DEBUGP("trying to timeout ct or exp for tuple ");
NF_CT_DUMP_TUPLE(t);

h = nf_conntrack_find_get(t, NULL);
h = nf_conntrack_find_get(t);
if (h) {
sibling = nf_ct_tuplehash_to_ctrack(h);
DEBUGP("setting timeout of conntrack %p to 0\n", sibling);
Expand Down

0 comments on commit d336ab1

Please sign in to comment.