Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 373443
b: refs/heads/master
c: a5a337d
h: refs/heads/master
i:
  373441: 7f587a7
  373439: 60fd963
v: v3
  • Loading branch information
Alex Elder authored and Sage Weil committed May 2, 2013
1 parent 6c51c6d commit d33a659
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 5cbf6f12c48121199cc214c93dea98cce719343b
refs/heads/master: a5a337d4382dfe0f9e9e072e7d3eaad8e05e4b0b
13 changes: 9 additions & 4 deletions trunk/drivers/block/rbd.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ struct rbd_img_request {
spinlock_t completion_lock;/* protects next_completion */
u32 next_completion;
rbd_img_callback_t callback;
int result; /* first nonzero obj_request result */

u32 obj_request_count;
struct list_head obj_requests; /* rbd_obj_request structs */
Expand Down Expand Up @@ -1488,6 +1489,7 @@ static struct rbd_img_request *rbd_img_request_create(
spin_lock_init(&img_request->completion_lock);
img_request->next_completion = 0;
img_request->callback = NULL;
img_request->result = 0;
img_request->obj_request_count = 0;
INIT_LIST_HEAD(&img_request->obj_requests);
kref_init(&img_request->kref);
Expand Down Expand Up @@ -1552,13 +1554,16 @@ static void rbd_img_obj_callback(struct rbd_obj_request *obj_request)
if (!obj_request_done_test(obj_request))
break;

rbd_assert(obj_request->xferred <= (u64) UINT_MAX);
xferred = (unsigned int) obj_request->xferred;
result = (int) obj_request->result;
if (result)
rbd_assert(obj_request->xferred <= (u64)UINT_MAX);
xferred = (unsigned int)obj_request->xferred;
result = obj_request->result;
if (result) {
rbd_warn(NULL, "obj_request %s result %d xferred %u\n",
img_request->write_request ? "write" : "read",
result, xferred);
if (!img_request->result)
img_request->result = result;
}

more = blk_end_request(img_request->rq, result, xferred);
which++;
Expand Down

0 comments on commit d33a659

Please sign in to comment.