Skip to content

Commit

Permalink
KVM: PPC: Book3s: PR: No irq_disable in vcpu_run
Browse files Browse the repository at this point in the history
Somewhere during merges we ended up from

  local_irq_enable()
  foo();
  local_irq_disable()

to always keeping irqs enabled during that part. However, we now
have the following code:

  foo();
  local_irq_disable()

which disables interrupts without the surrounding code enabling them
again! So let's remove that disable and be happy.

Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
Alexander Graf authored and Avi Kivity committed Mar 5, 2012
1 parent 7d82714 commit d33ad32
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions arch/powerpc/kvm/book3s_pr.c
Original file line number Diff line number Diff line change
Expand Up @@ -983,8 +983,6 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu)

kvm_guest_exit();

local_irq_disable();

current->thread.regs->msr = ext_msr;

/* Make sure we save the guest FPU/Altivec/VSX state */
Expand Down

0 comments on commit d33ad32

Please sign in to comment.