Skip to content

Commit

Permalink
[IPV6]: ipv6_fl_socklist is inadvertently shared.
Browse files Browse the repository at this point in the history
The ipv6_fl_socklist from listening socket is inadvertently shared
with new socket created for connection.  This leads to a variety of
interesting, but fatal, bugs. For example, removing one of the
sockets may lead to the other socket's encountering a page fault
when the now freed list is referenced.

The fix is to not share the flow label list with the new socket.

Signed-off-by: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Masayuki Nakagawa authored and David S. Miller committed Mar 16, 2007
1 parent 53cdcc0 commit d35690b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/ipv6/tcp_ipv6.c
Original file line number Diff line number Diff line change
Expand Up @@ -1453,6 +1453,7 @@ static struct sock * tcp_v6_syn_recv_sock(struct sock *sk, struct sk_buff *skb,
First: no IPv4 options.
*/
newinet->opt = NULL;
newnp->ipv6_fl_list = NULL;

/* Clone RX bits */
newnp->rxopt.all = np->rxopt.all;
Expand Down

0 comments on commit d35690b

Please sign in to comment.