Skip to content

Commit

Permalink
xen: netback: remove redundant xenvif_put
Browse files Browse the repository at this point in the history
netbk_fatal_tx_err() calls xenvif_carrier_off(), which does
a xenvif_put(). As callers of netbk_fatal_tx_err should only
have one reference to the vif at this time, then the xenvif_put
in netbk_fatal_tx_err is one too many.

Signed-off-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Andrew Jones authored and David S. Miller committed Feb 19, 2013
1 parent 07dcf8e commit d372045
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/net/xen-netback/netback.c
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,6 @@ static void netbk_fatal_tx_err(struct xenvif *vif)
{
netdev_err(vif->dev, "fatal error; disabling device\n");
xenvif_carrier_off(vif);
xenvif_put(vif);
}

static int netbk_count_requests(struct xenvif *vif,
Expand Down

0 comments on commit d372045

Please sign in to comment.