Skip to content

Commit

Permalink
[PATCH] ioc4_serial: Remove bogus error message
Browse files Browse the repository at this point in the history
This change removes a bogus error message from the IOC4 serial driver
interrupt handler.

This error message is bogus for two reasons.  First, it can never occur
given that current code takes care to initialize IOC4 in such a way that
these "unknown" interrupts could never occur.  Second, this code fails to
take into account that other drivers can share the IOC4 interrupt mechanism
through SA_SHIRQ, and thus this driver is not in-fact "all-knowing".

Finally, this error message triggers every time some "unknown" interrupt
occurs -- it's not rate limited or repetition limited in any way, thereby
effectively denying use of the console device.  Given its bogosity in the
first place, it's best to just get rid of it entirely.

Acked-by: Pat Gefre <pfg@sgi.com>
Signed-off-by: Brent Casavant <bcasavan@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Brent Casavant authored and Linus Torvalds committed Sep 30, 2005
1 parent dd190d0 commit d38e24e
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions drivers/serial/ioc4_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -973,18 +973,6 @@ static irqreturn_t ioc4_intr(int irq, void *arg, struct pt_regs *regs)
this_ir &= ~this_mir;
}
}
if (this_ir) {
printk(KERN_ERR
"unknown IOC4 %s interrupt 0x%x, sio_ir = 0x%x,"
" sio_ies = 0x%x, other_ir = 0x%x :"
"other_ies = 0x%x\n",
(intr_type == IOC4_SIO_INTR_TYPE) ? "sio" :
"other", this_ir,
readl(&soft->is_ioc4_misc_addr->sio_ir.raw),
readl(&soft->is_ioc4_misc_addr->sio_ies.raw),
readl(&soft->is_ioc4_misc_addr->other_ir.raw),
readl(&soft->is_ioc4_misc_addr->other_ies.raw));
}
}
#ifdef DEBUG_INTERRUPTS
{
Expand Down

0 comments on commit d38e24e

Please sign in to comment.