Skip to content

Commit

Permalink
sysrq: Properly check for kernel threads
Browse files Browse the repository at this point in the history
There's a real possibility of killing kernel threads that might
have issued use_mm(), so kthread's mm might become non-NULL.

This patch fixes the issue by checking for PF_KTHREAD (just as
get_task_mm()).

Suggested-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Anton Vorontsov authored and Greg Kroah-Hartman committed Feb 9, 2012
1 parent e502bab commit d3a532a
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/tty/sysrq.c
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,12 @@ static void send_sig_all(int sig)

read_lock(&tasklist_lock);
for_each_process(p) {
if (p->mm && !is_global_init(p))
/* Not swapper, init nor kernel thread */
force_sig(sig, p);
if (p->flags & PF_KTHREAD)
continue;
if (is_global_init(p))
continue;

force_sig(sig, p);
}
read_unlock(&tasklist_lock);
}
Expand Down

0 comments on commit d3a532a

Please sign in to comment.