Skip to content

Commit

Permalink
NFC: Removed addressed shdlc TODOs
Browse files Browse the repository at this point in the history
The questions asked in the comments have been answered and addressed.

Signed-off-by: Eric Lapuyade <eric.lapuyade@intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Eric Lapuyade authored and John W. Linville committed Jul 9, 2012
1 parent a9a741a commit d3b4044
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions net/nfc/hci/shdlc.c
Original file line number Diff line number Diff line change
Expand Up @@ -340,15 +340,6 @@ static void nfc_shdlc_connect_complete(struct nfc_shdlc *shdlc, int r)
shdlc->state = SHDLC_CONNECTED;
} else {
shdlc->state = SHDLC_DISCONNECTED;

/*
* TODO: Could it be possible that there are pending
* executing commands that are waiting for connect to complete
* before they can be carried? As connect is a blocking
* operation, it would require that the userspace process can
* send commands on the same device from a second thread before
* the device is up. I don't think that is possible, is it?
*/
}

shdlc->connect_result = r;
Expand Down Expand Up @@ -926,8 +917,6 @@ void nfc_shdlc_free(struct nfc_shdlc *shdlc)
{
pr_debug("\n");

/* TODO: Check that this cannot be called while still in use */

nfc_hci_unregister_device(shdlc->hdev);
nfc_hci_free_device(shdlc->hdev);

Expand Down

0 comments on commit d3b4044

Please sign in to comment.