Skip to content

Commit

Permalink
[PATCH] x86-64/i386: Don't process APICs/IO-APICs in ACPI when APIC i…
Browse files Browse the repository at this point in the history
…s disabled.

When nolapic was passed or the local APIC was disabled
for another reason ACPI would still parse the IO-APICs
until these were explicitely disabled with noapic.

Usually this resulted in a non booting configuration unless
"nolapic noapic" was used.

I also disabled the local APIC parsing in this case, although
that's only cosmetic (suppresses a few printks)

This hopefully makes nolapic work in all cases.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Apr 9, 2006
1 parent ec0f08e commit d3b6a34
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion arch/i386/kernel/acpi/boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ static int __init acpi_parse_madt(unsigned long phys_addr, unsigned long size)
{
struct acpi_table_madt *madt = NULL;

if (!phys_addr || !size)
if (!phys_addr || !size || !cpu_has_apic)
return -EINVAL;

madt = (struct acpi_table_madt *)__acpi_map_table(phys_addr, size);
Expand Down Expand Up @@ -751,6 +751,9 @@ static int __init acpi_parse_madt_ioapic_entries(void)
return -ENODEV;
}

if (!cpu_has_apic)
return -ENODEV;

/*
* if "noapic" boot option, don't look for IO-APICs
*/
Expand Down

0 comments on commit d3b6a34

Please sign in to comment.