Skip to content

Commit

Permalink
[CIFS] Fix ordering of cleanup on module init failure
Browse files Browse the repository at this point in the history
If registering fs cache failed, we weren't cleaning up proc.

Acked-by: Jeff Layton <jlayton@redhat.com>
CC: Suresh Jayaraman <sjayaraman@suse.de>
Signed-off-by: Steve French <sfrench@us.ibm.com>
  • Loading branch information
Steve French committed Sep 29, 2010
1 parent 17edec6 commit d3bf522
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
18 changes: 9 additions & 9 deletions fs/cifs/cifsfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -933,11 +933,11 @@ init_cifs(void)

rc = cifs_fscache_register();
if (rc)
goto out;
goto out_clean_proc;

rc = cifs_init_inodecache();
if (rc)
goto out_clean_proc;
goto out_unreg_fscache;

rc = cifs_init_mids();
if (rc)
Expand All @@ -959,19 +959,19 @@ init_cifs(void)
return 0;

#ifdef CONFIG_CIFS_UPCALL
out_unregister_filesystem:
out_unregister_filesystem:
unregister_filesystem(&cifs_fs_type);
#endif
out_destroy_request_bufs:
out_destroy_request_bufs:
cifs_destroy_request_bufs();
out_destroy_mids:
out_destroy_mids:
cifs_destroy_mids();
out_destroy_inodecache:
out_destroy_inodecache:
cifs_destroy_inodecache();
out_clean_proc:
cifs_proc_clean();
out_unreg_fscache:
cifs_fscache_unregister();
out:
out_clean_proc:
cifs_proc_clean();
return rc;
}

Expand Down
1 change: 0 additions & 1 deletion fs/cifs/connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
#include "ntlmssp.h"
#include "nterr.h"
#include "rfc1002pdu.h"
#include "cn_cifs.h"
#include "fscache.h"

#define CIFS_PORT 445
Expand Down

0 comments on commit d3bf522

Please sign in to comment.