Skip to content

Commit

Permalink
thermal: Exynos: Deletion of unnecessary checks before two function c…
Browse files Browse the repository at this point in the history
…alls

The functions cpufreq_cooling_unregister() and thermal_zone_device_unregister()
test whether their argument is NULL and then return immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
  • Loading branch information
Markus Elfring authored and Eduardo Valentin committed Nov 21, 2014
1 parent e60a342 commit d3e1956
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/thermal/samsung/exynos_thermal_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -417,13 +417,10 @@ void exynos_unregister_thermal(struct thermal_sensor_conf *sensor_conf)

th_zone = sensor_conf->pzone_data;

if (th_zone->therm_dev)
thermal_zone_device_unregister(th_zone->therm_dev);
thermal_zone_device_unregister(th_zone->therm_dev);

for (i = 0; i < th_zone->cool_dev_size; i++) {
if (th_zone->cool_dev[i])
cpufreq_cooling_unregister(th_zone->cool_dev[i]);
}
for (i = 0; i < th_zone->cool_dev_size; ++i)
cpufreq_cooling_unregister(th_zone->cool_dev[i]);

dev_info(sensor_conf->dev,
"Exynos: Kernel Thermal management unregistered\n");
Expand Down

0 comments on commit d3e1956

Please sign in to comment.