Skip to content

Commit

Permalink
x86: Disable CLFLUSH support again
Browse files Browse the repository at this point in the history
It turns out CLFLUSH support is still not complete; we
flush the wrong pages.  Again disable it for the release.
Noticed by Jan Beulich who then also noticed a stupid typo later.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Aug 11, 2007
1 parent 3f3f7b7 commit d3f3c93
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion arch/i386/mm/pageattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ static void flush_kernel_map(void *arg)
struct page *p;

/* High level code is not ready for clflush yet */
if (cpu_has_clflush) {
if (0 && cpu_has_clflush) {
list_for_each_entry (p, lh, lru)
cache_flush_page(p);
} else if (boot_cpu_data.x86_model >= 4)
Expand Down
3 changes: 2 additions & 1 deletion arch/x86_64/mm/pageattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ static void flush_kernel_map(void *arg)

/* When clflush is available always use it because it is
much cheaper than WBINVD. */
if (!cpu_has_clflush)
/* clflush is still broken. Disable for now. */
if (1 || !cpu_has_clflush)
asm volatile("wbinvd" ::: "memory");
else list_for_each_entry(pg, l, lru) {
void *adr = page_address(pg);
Expand Down

0 comments on commit d3f3c93

Please sign in to comment.