Skip to content

Commit

Permalink
ext4: fix ext4 so it works without CONFIG_PROC_FS
Browse files Browse the repository at this point in the history
This fixes a bug which was introduced in dd68314.  The problem
came from the test of the return value of proc_mkdir which is always
false without procfs, and this would initialization of ext4.

Signed-off-by: Fabrice Jouhaud <yargil@free.fr>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Fabrice Jouhaud authored and Theodore Ts'o committed Oct 8, 2011
1 parent 6ee3b21 commit d44651d
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions fs/ext4/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -3540,10 +3540,8 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
goto failed_mount;
}

#ifdef CONFIG_PROC_FS
if (ext4_proc_root)
sbi->s_proc = proc_mkdir(sb->s_id, ext4_proc_root);
#endif

bgl_lock_init(sbi->s_blockgroup_lock);

Expand Down Expand Up @@ -5070,13 +5068,11 @@ static int __init ext4_init_fs(void)
return err;
err = ext4_init_system_zone();
if (err)
goto out7;
goto out6;
ext4_kset = kset_create_and_add("ext4", NULL, fs_kobj);
if (!ext4_kset)
goto out6;
ext4_proc_root = proc_mkdir("fs/ext4", NULL);
if (!ext4_proc_root)
goto out5;
ext4_proc_root = proc_mkdir("fs/ext4", NULL);

err = ext4_init_feat_adverts();
if (err)
Expand Down Expand Up @@ -5112,12 +5108,12 @@ static int __init ext4_init_fs(void)
out3:
ext4_exit_feat_adverts();
out4:
remove_proc_entry("fs/ext4", NULL);
out5:
if (ext4_proc_root)
remove_proc_entry("fs/ext4", NULL);
kset_unregister(ext4_kset);
out6:
out5:
ext4_exit_system_zone();
out7:
out6:
ext4_exit_pageio();
return err;
}
Expand Down

0 comments on commit d44651d

Please sign in to comment.