Skip to content

Commit

Permalink
[SCTP]: sctp_transport_route() switched to net-endian.
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Al Viro authored and David S. Miller committed Dec 3, 2006
1 parent cb7b4a0 commit d448388
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
4 changes: 3 additions & 1 deletion net/sctp/sm_statefuns.c
Original file line number Diff line number Diff line change
Expand Up @@ -5103,6 +5103,7 @@ static struct sctp_packet *sctp_ootb_pkt_new(const struct sctp_association *asoc
__u16 sport;
__u16 dport;
__u32 vtag;
union sctp_addr tmp;

/* Get the source and destination port from the inbound packet. */
sport = ntohs(chunk->sctp_hdr->dest);
Expand Down Expand Up @@ -5140,7 +5141,8 @@ static struct sctp_packet *sctp_ootb_pkt_new(const struct sctp_association *asoc
/* Cache a route for the transport with the chunk's destination as
* the source address.
*/
sctp_transport_route(transport, (union sctp_addr *)&chunk->dest,
flip_to_n(&tmp, &chunk->dest);
sctp_transport_route(transport, &tmp,
sctp_sk(sctp_get_ctl_sock()));

packet = sctp_packet_init(&transport->packet, transport, sport, dport);
Expand Down
14 changes: 5 additions & 9 deletions net/sctp/transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,19 +253,15 @@ void sctp_transport_route(struct sctp_transport *transport,
struct sctp_af *af = transport->af_specific;
union sctp_addr *daddr = &transport->ipaddr;
struct dst_entry *dst;
union sctp_addr tmp;
flip_to_n(&tmp, saddr);

dst = af->get_dst(asoc, daddr, &tmp);
dst = af->get_dst(asoc, daddr, saddr);

if (saddr) {
memcpy(&transport->saddr_h, saddr, sizeof(union sctp_addr));
flip_to_n(&transport->saddr, &transport->saddr_h);
} else {
if (saddr)
memcpy(&transport->saddr, saddr, sizeof(union sctp_addr));
else
af->get_saddr(asoc, dst, daddr, &transport->saddr);
flip_to_h(&transport->saddr_h, &transport->saddr);
}

flip_to_h(&transport->saddr_h, &transport->saddr);
transport->dst = dst;
if ((transport->param_flags & SPP_PMTUD_DISABLE) && transport->pathmtu) {
return;
Expand Down

0 comments on commit d448388

Please sign in to comment.