Skip to content

Commit

Permalink
staging: line6: drop variax active sysfs attr
Browse files Browse the repository at this point in the history
The get_string() function has no other callers so remove it too.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Stefan Hajnoczi authored and Greg Kroah-Hartman committed Nov 27, 2012
1 parent 502eb4e commit d46e7c2
Showing 1 changed file with 0 additions and 36 deletions.
36 changes: 0 additions & 36 deletions drivers/staging/line6/variax.c
Original file line number Diff line number Diff line change
Expand Up @@ -275,38 +275,6 @@ void line6_variax_process_message(struct usb_line6_variax *variax)
}
}

/*
"read" request on "active" special file.
*/
static ssize_t variax_get_active(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct usb_line6_variax *variax =
usb_get_intfdata(to_usb_interface(dev));
return sprintf(buf, "%d\n",
variax->buffer_activate[VARIAX_OFFSET_ACTIVATE]);
}

/*
"write" request on "active" special file.
*/
static ssize_t variax_set_active(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
{
struct usb_line6_variax *variax =
usb_get_intfdata(to_usb_interface(dev));
u8 value;
int ret;

ret = kstrtou8(buf, 10, &value);
if (ret)
return ret;

variax_activate_async(variax, value ? 1 : 0);
return count;
}

/*
"read" request on "guitar" special file.
*/
Expand Down Expand Up @@ -366,8 +334,6 @@ static ssize_t variax_set_raw2(struct device *dev,
#endif

/* Variax workbench special files: */
static DEVICE_ATTR(active, S_IWUSR | S_IRUGO, variax_get_active,
variax_set_active);
static DEVICE_ATTR(guitar, S_IRUGO, variax_get_guitar, line6_nop_write);

#ifdef CONFIG_LINE6_USB_RAW
Expand Down Expand Up @@ -404,7 +370,6 @@ static void variax_destruct(struct usb_interface *interface)
static int variax_create_files2(struct device *dev)
{
int err;
CHECK_RETURN(device_create_file(dev, &dev_attr_active));
CHECK_RETURN(device_create_file(dev, &dev_attr_guitar));
#ifdef CONFIG_LINE6_USB_RAW
CHECK_RETURN(device_create_file(dev, &dev_attr_raw));
Expand Down Expand Up @@ -504,7 +469,6 @@ void line6_variax_disconnect(struct usb_interface *interface)
if (dev != NULL) {
/* remove sysfs entries: */
line6_variax_remove_files(0, 0, dev);
device_remove_file(dev, &dev_attr_active);
device_remove_file(dev, &dev_attr_guitar);
#ifdef CONFIG_LINE6_USB_RAW
device_remove_file(dev, &dev_attr_raw);
Expand Down

0 comments on commit d46e7c2

Please sign in to comment.