Skip to content

Commit

Permalink
crypto: tegra-aes - fix error-valued pointer dereference
Browse files Browse the repository at this point in the history
clk_put(dd->aes_clk) will dereference an error-valued pointer since the
dd->aes_clk is a ERR_PTR() value. The correct check is call clk_put()
if !IS_ERR(dd->aes_clk).

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Wei Yongjun authored and Herbert Xu committed Nov 9, 2012
1 parent 3200da8 commit d48e366
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/crypto/tegra-aes.c
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,7 @@ static int tegra_aes_probe(struct platform_device *pdev)
if (dd->buf_out)
dma_free_coherent(dev, AES_HW_DMA_BUFFER_SIZE_BYTES,
dd->buf_out, dd->dma_buf_out);
if (IS_ERR(dd->aes_clk))
if (!IS_ERR(dd->aes_clk))
clk_put(dd->aes_clk);
if (aes_wq)
destroy_workqueue(aes_wq);
Expand Down

0 comments on commit d48e366

Please sign in to comment.