Skip to content

Commit

Permalink
irqchip: crossbar: Remove IS_ERR_VALUE check
Browse files Browse the repository at this point in the history
IS_ERR_VALUE makes sense only *if* there could be valid values in
negative error range. But in the cases that we do use it, there is no
such case. Just remove the same.

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Link: https://lkml.kernel.org/r/1403766634-18543-7-git-send-email-r.sricharan@ti.com
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
  • Loading branch information
Nishanth Menon authored and Jason Cooper committed Jun 30, 2014
1 parent ddee0fb commit d4922a9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/irqchip/irq-crossbar.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,15 +102,15 @@ static int crossbar_domain_xlate(struct irq_domain *d,
unsigned long *out_hwirq,
unsigned int *out_type)
{
unsigned long ret;
int ret;

ret = get_prev_map_irq(intspec[1]);
if (!IS_ERR_VALUE(ret))
if (ret >= 0)
goto found;

ret = allocate_free_irq(intspec[1]);

if (IS_ERR_VALUE(ret))
if (ret < 0)
return ret;

found:
Expand Down

0 comments on commit d4922a9

Please sign in to comment.