Skip to content

Commit

Permalink
rpc: let xdr layer allocate gssproxy receieve pages
Browse files Browse the repository at this point in the history
In theory the linux cred in a gssproxy reply can include up to
NGROUPS_MAX data, 256K of data.  In the common case we expect it to be
shorter.  So do as the nfsv3 ACL code does and let the xdr code allocate
the pages as they come in, instead of allocating a lot of pages that
won't typically be used.

Tested-by: Simo Sorce <simo@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
J. Bruce Fields committed Sep 6, 2013
1 parent 9dfd87d commit d4a5165
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions net/sunrpc/auth_gss/gss_rpc_upcall.c
Original file line number Diff line number Diff line change
Expand Up @@ -223,18 +223,14 @@ static void gssp_free_receive_pages(struct gssx_arg_accept_sec_context *arg)

static int gssp_alloc_receive_pages(struct gssx_arg_accept_sec_context *arg)
{
int i;

arg->npages = DIV_ROUND_UP(NGROUPS_MAX * 4, PAGE_SIZE);
arg->pages = kzalloc(arg->npages * sizeof(struct page *), GFP_KERNEL);

for (i=0; i < arg->npages; i++) {
arg->pages[i] = alloc_page(GFP_KERNEL);
if (arg->pages[i] == NULL) {
gssp_free_receive_pages(arg);
return -ENOMEM;
}
}
/*
* XXX: actual pages are allocated by xdr layer in
* xdr_partial_copy_from_skb.
*/
if (!arg->pages)
return -ENOMEM;
return 0;
}

Expand Down

0 comments on commit d4a5165

Please sign in to comment.