Skip to content

Commit

Permalink
drm/radeon: make audio_init consistent across asics
Browse files Browse the repository at this point in the history
Call it in the asic startup callback on all asics.
Previously r600 and rv770 called it in the startup
and resume callbacks while all the other asics called
it in the startup callback.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
  • Loading branch information
Alex Deucher authored and Dave Airlie committed Jun 5, 2012
1 parent 99becf1 commit d4e30ef
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 33 deletions.
15 changes: 6 additions & 9 deletions drivers/gpu/drm/radeon/r600.c
Original file line number Diff line number Diff line change
Expand Up @@ -2426,6 +2426,12 @@ int r600_startup(struct radeon_device *rdev)
if (r)
return r;

r = r600_audio_init(rdev);
if (r) {
DRM_ERROR("radeon: audio init failed\n");
return r;
}

return 0;
}

Expand Down Expand Up @@ -2462,12 +2468,6 @@ int r600_resume(struct radeon_device *rdev)
return r;
}

r = r600_audio_init(rdev);
if (r) {
DRM_ERROR("radeon: audio resume failed\n");
return r;
}

return r;
}

Expand Down Expand Up @@ -2577,9 +2577,6 @@ int r600_init(struct radeon_device *rdev)
rdev->accel_working = false;
}

r = r600_audio_init(rdev);
if (r)
return r; /* TODO error handling */
return 0;
}

Expand Down
12 changes: 6 additions & 6 deletions drivers/gpu/drm/radeon/rs600.c
Original file line number Diff line number Diff line change
Expand Up @@ -908,12 +908,6 @@ static int rs600_startup(struct radeon_device *rdev)
return r;
}

r = r600_audio_init(rdev);
if (r) {
dev_err(rdev->dev, "failed initializing audio\n");
return r;
}

r = radeon_ib_pool_start(rdev);
if (r)
return r;
Expand All @@ -922,6 +916,12 @@ static int rs600_startup(struct radeon_device *rdev)
if (r)
return r;

r = r600_audio_init(rdev);
if (r) {
dev_err(rdev->dev, "failed initializing audio\n");
return r;
}

return 0;
}

Expand Down
12 changes: 6 additions & 6 deletions drivers/gpu/drm/radeon/rs690.c
Original file line number Diff line number Diff line change
Expand Up @@ -637,12 +637,6 @@ static int rs690_startup(struct radeon_device *rdev)
return r;
}

r = r600_audio_init(rdev);
if (r) {
dev_err(rdev->dev, "failed initializing audio\n");
return r;
}

r = radeon_ib_pool_start(rdev);
if (r)
return r;
Expand All @@ -651,6 +645,12 @@ static int rs690_startup(struct radeon_device *rdev)
if (r)
return r;

r = r600_audio_init(rdev);
if (r) {
dev_err(rdev->dev, "failed initializing audio\n");
return r;
}

return 0;
}

Expand Down
18 changes: 6 additions & 12 deletions drivers/gpu/drm/radeon/rv770.c
Original file line number Diff line number Diff line change
Expand Up @@ -956,6 +956,12 @@ static int rv770_startup(struct radeon_device *rdev)
if (r)
return r;

r = r600_audio_init(rdev);
if (r) {
DRM_ERROR("radeon: audio init failed\n");
return r;
}

return 0;
}

Expand All @@ -978,12 +984,6 @@ int rv770_resume(struct radeon_device *rdev)
return r;
}

r = r600_audio_init(rdev);
if (r) {
dev_err(rdev->dev, "radeon: audio init failed\n");
return r;
}

return r;

}
Expand Down Expand Up @@ -1092,12 +1092,6 @@ int rv770_init(struct radeon_device *rdev)
rdev->accel_working = false;
}

r = r600_audio_init(rdev);
if (r) {
dev_err(rdev->dev, "radeon: audio init failed\n");
return r;
}

return 0;
}

Expand Down

0 comments on commit d4e30ef

Please sign in to comment.