Skip to content

Commit

Permalink
do not change dead_task->exit_signal
Browse files Browse the repository at this point in the history
__ptrace_detach() and do_notify_parent() set task->exit_signal = -1
to mark the task dead. This is no longer needed, nobody checks
exit_signal to detect the EXIT_DEAD task.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Oleg Nesterov committed Jun 27, 2011
1 parent e550f14 commit d4f7c51
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion kernel/ptrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,6 @@ static bool __ptrace_detach(struct task_struct *tracer, struct task_struct *p)
dead = do_notify_parent(p, p->exit_signal);
else if (ignoring_children(tracer->sighand)) {
__wake_up_parent(p, tracer);
p->exit_signal = -1;
dead = true;
}
}
Expand Down
1 change: 0 additions & 1 deletion kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1650,7 +1650,6 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
* it, just use SIG_IGN instead).
*/
autoreap = true;
tsk->exit_signal = -1;
if (psig->action[SIGCHLD-1].sa.sa_handler == SIG_IGN)
sig = 0;
}
Expand Down

0 comments on commit d4f7c51

Please sign in to comment.