Skip to content

Commit

Permalink
cxgb4: set coalesce parameters on all queues
Browse files Browse the repository at this point in the history
The coalesce parameters was set only on the first queue, which caused
interrupt rates to be larger on all the other queues.

This patch allows interrupt rates to be reduced for certain workloads
and colaesce parameters by 41%.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Cc: steved@us.ibm.com
Cc: toml@us.ibm.com
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Thadeu Lima de Souza Cascardo authored and David S. Miller committed Jan 16, 2013
1 parent adbbf69 commit d4fc9dc
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1994,9 +1994,20 @@ static int set_coalesce(struct net_device *dev, struct ethtool_coalesce *c)
{
const struct port_info *pi = netdev_priv(dev);
struct adapter *adap = pi->adapter;

return set_rxq_intr_params(adap, &adap->sge.ethrxq[pi->first_qset].rspq,
c->rx_coalesce_usecs, c->rx_max_coalesced_frames);
struct sge_rspq *q;
int i;
int r = 0;

for (i = pi->first_qset; i < pi->first_qset + pi->nqsets; i++) {
q = &adap->sge.ethrxq[i].rspq;
r = set_rxq_intr_params(adap, q, c->rx_coalesce_usecs,
c->rx_max_coalesced_frames);
if (r) {
dev_err(&dev->dev, "failed to set coalesce %d\n", r);
break;
}
}
return r;
}

static int get_coalesce(struct net_device *dev, struct ethtool_coalesce *c)
Expand Down

0 comments on commit d4fc9dc

Please sign in to comment.