Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 350058
b: refs/heads/master
c: 51f27d1
h: refs/heads/master
v: v3
  • Loading branch information
Namhyung Kim authored and Arnaldo Carvalho de Melo committed Feb 6, 2013
1 parent 8854534 commit d53380f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 18 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 2209001fd895e8932ae2c85bfca233758234499a
refs/heads/master: 51f27d1440cede5a413d279a20b38767b6f85097
23 changes: 6 additions & 17 deletions trunk/tools/perf/util/sort.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,10 @@ struct sort_entry sort_dso = {

/* --sort symbol */

static int64_t _sort__sym_cmp(struct symbol *sym_l, struct symbol *sym_r,
u64 ip_l, u64 ip_r)
static int64_t _sort__sym_cmp(struct symbol *sym_l, struct symbol *sym_r)
{
u64 ip_l, ip_r;

if (!sym_l || !sym_r)
return cmp_null(sym_l, sym_r);

Expand All @@ -178,21 +179,10 @@ static int64_t _sort__sym_cmp(struct symbol *sym_l, struct symbol *sym_r,
static int64_t
sort__sym_cmp(struct hist_entry *left, struct hist_entry *right)
{
u64 ip_l, ip_r;

if (!left->ms.sym && !right->ms.sym)
return right->level - left->level;

if (!left->ms.sym || !right->ms.sym)
return cmp_null(left->ms.sym, right->ms.sym);

if (left->ms.sym == right->ms.sym)
return 0;

ip_l = left->ms.sym->start;
ip_r = right->ms.sym->start;

return _sort__sym_cmp(left->ms.sym, right->ms.sym, ip_l, ip_r);
return _sort__sym_cmp(left->ms.sym, right->ms.sym);
}

static int _hist_entry__sym_snprintf(struct map *map, struct symbol *sym,
Expand Down Expand Up @@ -383,8 +373,7 @@ sort__sym_from_cmp(struct hist_entry *left, struct hist_entry *right)
if (!from_l->sym && !from_r->sym)
return right->level - left->level;

return _sort__sym_cmp(from_l->sym, from_r->sym, from_l->addr,
from_r->addr);
return _sort__sym_cmp(from_l->sym, from_r->sym);
}

static int64_t
Expand All @@ -396,7 +385,7 @@ sort__sym_to_cmp(struct hist_entry *left, struct hist_entry *right)
if (!to_l->sym && !to_r->sym)
return right->level - left->level;

return _sort__sym_cmp(to_l->sym, to_r->sym, to_l->addr, to_r->addr);
return _sort__sym_cmp(to_l->sym, to_r->sym);
}

static int hist_entry__sym_from_snprintf(struct hist_entry *self, char *bf,
Expand Down

0 comments on commit d53380f

Please sign in to comment.