Skip to content

Commit

Permalink
KVM: x86 emulator: drop DPRINTF()
Browse files Browse the repository at this point in the history
Failed emulation is reported via a tracepoint; the cmps printk is pointless.

Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
  • Loading branch information
Avi Kivity committed Jan 12, 2011
1 parent 8a6bcaa commit d53db5e
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions arch/x86/kvm/emulate.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

#include <linux/kvm_host.h>
#include "kvm_cache_regs.h"
#define DPRINTF(x...) do {} while (0)
#include <linux/module.h>
#include <asm/kvm_emulate.h>

Expand Down Expand Up @@ -2796,10 +2795,8 @@ x86_decode_insn(struct x86_emulate_ctxt *ctxt)
c->execute = opcode.u.execute;

/* Unrecognised? */
if (c->d == 0 || (c->d & Undefined)) {
DPRINTF("Cannot emulate %02x\n", c->b);
if (c->d == 0 || (c->d & Undefined))
return -1;
}

if (mode == X86EMUL_MODE_PROT64 && (c->d & Stack))
c->op_bytes = 8;
Expand Down Expand Up @@ -3261,7 +3258,6 @@ x86_emulate_insn(struct x86_emulate_ctxt *ctxt)
break;
case 0xa6 ... 0xa7: /* cmps */
c->dst.type = OP_NONE; /* Disable writeback. */
DPRINTF("cmps: mem1=0x%p mem2=0x%p\n", c->src.addr.mem, c->dst.addr.mem);
goto cmp;
case 0xa8 ... 0xa9: /* test ax, imm */
goto test;
Expand Down Expand Up @@ -3778,6 +3774,5 @@ x86_emulate_insn(struct x86_emulate_ctxt *ctxt)
goto writeback;

cannot_emulate:
DPRINTF("Cannot emulate %02x\n", c->b);
return -1;
}

0 comments on commit d53db5e

Please sign in to comment.