Skip to content

Commit

Permalink
[media] cx23885: Don't use memset on vidioc_ callbacks
Browse files Browse the repository at this point in the history
vidioc_g_tuner should not do any memset for the parameters. Core
already does that. In particular, V4L2 core now does some handling
for the tuner type, and the tuner-core module relies on that.

So, doing any memset there is a very bad idea.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mauro Carvalho Chehab committed Oct 14, 2011
1 parent 97ce567 commit d5492fb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/media/video/cx23885/cx23885-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -1223,7 +1223,6 @@ static int vidioc_g_tuner(struct file *file, void *priv,
if (0 != t->index)
return -EINVAL;

memset(t, 0, sizeof(*t));
strcpy(t->name, "Television");

return 0;
Expand Down

0 comments on commit d5492fb

Please sign in to comment.