Skip to content

Commit

Permalink
[BRIDGE]: optimize frame pass up
Browse files Browse the repository at this point in the history
The netfilter hook that is used to receive frames doesn't need to be a
stub.  It is only called in two ways, both of which ignore the return
value.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Mar 21, 2006
1 parent cee4854 commit d5513a7
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions net/bridge/br_input.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@

const unsigned char bridge_ula[6] = { 0x01, 0x80, 0xc2, 0x00, 0x00, 0x00 };

static int br_pass_frame_up_finish(struct sk_buff *skb)
{
netif_receive_skb(skb);
return 0;
}

static void br_pass_frame_up(struct net_bridge *br, struct sk_buff *skb)
{
struct net_device *indev;
Expand All @@ -38,7 +32,7 @@ static void br_pass_frame_up(struct net_bridge *br, struct sk_buff *skb)
skb->dev = br->dev;

NF_HOOK(PF_BRIDGE, NF_BR_LOCAL_IN, skb, indev, NULL,
br_pass_frame_up_finish);
netif_receive_skb);
}

/* note: already called with rcu_read_lock (preempt_disabled) */
Expand Down

0 comments on commit d5513a7

Please sign in to comment.