Skip to content

Commit

Permalink
mfd: ab8500-debugfs: Apply a check for -ENOMEM after allocating memor…
Browse files Browse the repository at this point in the history
…y for event name

The AB8500 debugfs driver allocates memory to contain the name of a new sysfs
entry, but fails to apply the proper post-allocation checks. If the device
were to run out of memory, the allocation would return NULL. Without the
correct checks the driver will continue to populate address NULL with the
specified device name which would obviously cause a pointer dereference Oops.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
  • Loading branch information
Lee Jones committed Sep 2, 2013
1 parent f840e23 commit d551c4c
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/mfd/ab8500-debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -2804,6 +2804,9 @@ static ssize_t ab8500_subscribe_write(struct file *file,
return -ENOMEM;

event_name[irq_index] = kmalloc(count, GFP_KERNEL);
if (!event_name[irq_index])
return -ENOMEM;

sprintf(event_name[irq_index], "%lu", user_val);
dev_attr[irq_index]->show = show_irq;
dev_attr[irq_index]->store = NULL;
Expand Down

0 comments on commit d551c4c

Please sign in to comment.