Skip to content

Commit

Permalink
param: fix NULL comparison on oom
Browse files Browse the repository at this point in the history
kp->arg is always true: it's the contents of that pointer we care about.

Reported-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org
  • Loading branch information
Rusty Russell committed Oct 28, 2009
1 parent 65afac7 commit d553ad8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/params.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ int param_set_charp(const char *val, struct kernel_param *kp)
* don't need to; this mangled commandline is preserved. */
if (slab_is_available()) {
*(char **)kp->arg = kstrdup(val, GFP_KERNEL);
if (!kp->arg)
if (!*(char **)kp->arg)
return -ENOMEM;
} else
*(const char **)kp->arg = val;
Expand Down

0 comments on commit d553ad8

Please sign in to comment.