Skip to content

Commit

Permalink
ASoC: fsl: remove unnecessary call to dma_unmap_single
Browse files Browse the repository at this point in the history
Remove a call to dma_unmap_single() from the PowerPC ASoC DMA driver.  The
buffer is allocated and not actually mapped, so the unmap call doesn't
make sense.  It was probably left over from some early version of the driver.

This bug was unnoticed for so long because the DMA mapping functions normally
don't do anything on PowerPC.

Signed-off-by: Timur Tabi <timur@freescale.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Timur Tabi authored and Mark Brown committed Sep 19, 2012
1 parent 13c57e5 commit d55438b
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions sound/soc/fsl/fsl_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -823,12 +823,6 @@ static int fsl_dma_close(struct snd_pcm_substream *substream)
if (dma_private->irq)
free_irq(dma_private->irq, dma_private);

if (dma_private->ld_buf_phys) {
dma_unmap_single(dev, dma_private->ld_buf_phys,
sizeof(dma_private->link),
DMA_TO_DEVICE);
}

/* Deallocate the fsl_dma_private structure */
dma_free_coherent(dev, sizeof(struct fsl_dma_private),
dma_private, dma_private->ld_buf_phys);
Expand Down

0 comments on commit d55438b

Please sign in to comment.