Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 100269
b: refs/heads/master
c: 0911810
h: refs/heads/master
i:
  100267: 5269d6e
v: v3
  • Loading branch information
Jonathan Corbet committed May 18, 2008
1 parent c6bef3f commit d55634a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3db633ee352bfe20d4a2b0c3c8a46ce31a6c7149
refs/heads/master: 0911810755fc9f15659cc3cb43912633b90027a0
22 changes: 16 additions & 6 deletions trunk/drivers/net/wan/cosa.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@
#include <linux/spinlock.h>
#include <linux/mutex.h>
#include <linux/device.h>
#include <linux/smp_lock.h>

#undef COSA_SLOW_IO /* for testing purposes only */

Expand Down Expand Up @@ -970,15 +971,21 @@ static int cosa_open(struct inode *inode, struct file *file)
struct channel_data *chan;
unsigned long flags;
int n;
int ret = 0;

lock_kernel();
if ((n=iminor(file->f_path.dentry->d_inode)>>CARD_MINOR_BITS)
>= nr_cards)
return -ENODEV;
>= nr_cards) {
ret = -ENODEV;
goto out;
}
cosa = cosa_cards+n;

if ((n=iminor(file->f_path.dentry->d_inode)
& ((1<<CARD_MINOR_BITS)-1)) >= cosa->nchannels)
return -ENODEV;
& ((1<<CARD_MINOR_BITS)-1)) >= cosa->nchannels) {
ret = -ENODEV;
goto out;
}
chan = cosa->chan + n;

file->private_data = chan;
Expand All @@ -987,7 +994,8 @@ static int cosa_open(struct inode *inode, struct file *file)

if (chan->usage < 0) { /* in netdev mode */
spin_unlock_irqrestore(&cosa->lock, flags);
return -EBUSY;
ret = -EBUSY;
goto out;
}
cosa->usage++;
chan->usage++;
Expand All @@ -996,7 +1004,9 @@ static int cosa_open(struct inode *inode, struct file *file)
chan->setup_rx = chrdev_setup_rx;
chan->rx_done = chrdev_rx_done;
spin_unlock_irqrestore(&cosa->lock, flags);
return 0;
out:
unlock_kernel();
return ret;
}

static int cosa_release(struct inode *inode, struct file *file)
Expand Down

0 comments on commit d55634a

Please sign in to comment.