Skip to content

Commit

Permalink
dmaengine: timb_dma: fix the spare warinings
Browse files Browse the repository at this point in the history
Sparse warns:

drivers/dma/timb_dma.c:168:17: warning: mixing different enum types
drivers/dma/timb_dma.c:168:17:     int enum dma_transfer_direction versus
drivers/dma/timb_dma.c:168:17:     int enum dma_data_direction
drivers/dma/timb_dma.c:172:32: warning: mixing different enum types
drivers/dma/timb_dma.c:172:32:     int enum dma_transfer_direction versus
drivers/dma/timb_dma.c:172:32:     int enum dma_data_direction

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
  • Loading branch information
Vinod Koul committed Nov 28, 2011
1 parent 61e183f commit d561394
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/dma/timb_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,10 @@ static void __td_unmap_desc(struct timb_dma_chan *td_chan, const u8 *dma_desc,

if (single)
dma_unmap_single(chan2dev(&td_chan->chan), addr, len,
td_chan->direction);
DMA_TO_DEVICE);
else
dma_unmap_page(chan2dev(&td_chan->chan), addr, len,
td_chan->direction);
DMA_TO_DEVICE);
}

static void __td_unmap_descs(struct timb_dma_desc *td_desc, bool single)
Expand Down Expand Up @@ -398,7 +398,7 @@ static struct timb_dma_desc *td_alloc_init_desc(struct timb_dma_chan *td_chan)
td_desc->txd.flags = DMA_CTRL_ACK;

td_desc->txd.phys = dma_map_single(chan2dmadev(chan),
td_desc->desc_list, td_desc->desc_list_len, DMA_MEM_TO_DEV);
td_desc->desc_list, td_desc->desc_list_len, DMA_TO_DEVICE);

err = dma_mapping_error(chan2dmadev(chan), td_desc->txd.phys);
if (err) {
Expand All @@ -419,7 +419,7 @@ static void td_free_desc(struct timb_dma_desc *td_desc)
{
dev_dbg(chan2dev(td_desc->txd.chan), "Freeing desc: %p\n", td_desc);
dma_unmap_single(chan2dmadev(td_desc->txd.chan), td_desc->txd.phys,
td_desc->desc_list_len, DMA_MEM_TO_DEV);
td_desc->desc_list_len, DMA_TO_DEVICE);

kfree(td_desc->desc_list);
kfree(td_desc);
Expand Down

0 comments on commit d561394

Please sign in to comment.