Skip to content

Commit

Permalink
[PATCH] i2c: drop empty i2c_driver.command implementations
Browse files Browse the repository at this point in the history
Given that implementing i2c_driver.command is optional, there is no
point in an empty implementation thereof.

Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Michael Geng <linux@MichaelGeng.de>
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Laurent Riffard authored and Greg Kroah-Hartman committed Jan 6, 2006
1 parent 04b4b84 commit d564bae
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 26 deletions.
7 changes: 0 additions & 7 deletions drivers/i2c/i2c-dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -464,12 +464,6 @@ static int i2cdev_detach_client(struct i2c_client *client)
return 0;
}

static int i2cdev_command(struct i2c_client *client, unsigned int cmd,
void *arg)
{
return -1;
}

static struct i2c_driver i2cdev_driver = {
.driver = {
.name = "dev_driver",
Expand All @@ -478,7 +472,6 @@ static struct i2c_driver i2cdev_driver = {
.attach_adapter = i2cdev_attach_adapter,
.detach_adapter = i2cdev_detach_adapter,
.detach_client = i2cdev_detach_client,
.command = i2cdev_command,
};

static struct i2c_client i2cdev_client_template = {
Expand Down
7 changes: 0 additions & 7 deletions drivers/media/video/saa5246a.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,6 @@ static int saa5246a_detach(struct i2c_client *client)
return 0;
}

static int saa5246a_command(struct i2c_client *device, unsigned int cmd,
void *arg)
{
return -EINVAL;
}

/*
* I2C interfaces
*/
Expand All @@ -169,7 +163,6 @@ static struct i2c_driver i2c_driver_videotext =
.id = I2C_DRIVERID_SAA5249, /* in i2c.h */
.attach_adapter = saa5246a_probe,
.detach_client = saa5246a_detach,
.command = saa5246a_command
};

static struct i2c_client client_template = {
Expand Down
7 changes: 0 additions & 7 deletions drivers/media/video/saa5249.c
Original file line number Diff line number Diff line change
Expand Up @@ -226,12 +226,6 @@ static int saa5249_detach(struct i2c_client *client)
return 0;
}

static int saa5249_command(struct i2c_client *device,
unsigned int cmd, void *arg)
{
return -EINVAL;
}

/* new I2C driver support */

static struct i2c_driver i2c_driver_videotext =
Expand All @@ -242,7 +236,6 @@ static struct i2c_driver i2c_driver_videotext =
.id = I2C_DRIVERID_SAA5249, /* in i2c.h */
.attach_adapter = saa5249_probe,
.detach_client = saa5249_detach,
.command = saa5249_command
};

static struct i2c_client client_template = {
Expand Down
5 changes: 0 additions & 5 deletions drivers/video/matrox/matroxfb_maven.c
Original file line number Diff line number Diff line change
Expand Up @@ -1288,18 +1288,13 @@ static int maven_detach_client(struct i2c_client* client) {
return 0;
}

static int maven_command(struct i2c_client* client, unsigned int cmd, void* arg) {
return -ENOIOCTLCMD; /* or -EINVAL, depends on who will call this */
}

static struct i2c_driver maven_driver={
.driver = {
.name = "maven",
},
.id = I2C_DRIVERID_MGATVO,
.attach_adapter = maven_attach_adapter,
.detach_client = maven_detach_client,
.command = maven_command,
};

/* ************************** */
Expand Down

0 comments on commit d564bae

Please sign in to comment.