Skip to content

Commit

Permalink
staging:iio:ade7753: Do not return a error in remove function
Browse files Browse the repository at this point in the history
In the Linux device driver model the remove callback is not allowed to fail and
the device will be removed regardless of the return value of the remove
callback. So if we abort in the remove function and do not free all resources we
will create a resource leak. Also all kinds of undefined behaviour are expected
to happen since the IIO device is still there while its parent is already gone.

The error which the driver tries to handle in the remove function is
non-critical, so we can just ignore it and continue to free all resources and
remove the IIO device.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Lars-Peter Clausen authored and Jonathan Cameron committed Sep 22, 2012
1 parent 0b4ac3d commit d576c75
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions drivers/staging/iio/meter/ade7753.c
Original file line number Diff line number Diff line change
Expand Up @@ -557,18 +557,13 @@ static int __devinit ade7753_probe(struct spi_device *spi)
/* fixme, confirm ordering in this function */
static int __devexit ade7753_remove(struct spi_device *spi)
{
int ret;
struct iio_dev *indio_dev = spi_get_drvdata(spi);

iio_device_unregister(indio_dev);

ret = ade7753_stop_device(&(indio_dev->dev));
if (ret)
goto err_ret;

ade7753_stop_device(&indio_dev->dev);
iio_device_free(indio_dev);
err_ret:
return ret;

return 0;
}

static struct spi_driver ade7753_driver = {
Expand Down

0 comments on commit d576c75

Please sign in to comment.