Skip to content

Commit

Permalink
V4L/DVB: cx231xx: cleanup dvb_attach() return value handling
Browse files Browse the repository at this point in the history
Remove the following sparse error (see "make C=1"):
 * error: incompatible types for operation (<)
       left side has type struct dvb_frontend *
       right side has type int

Signed-off-by: Márton Németh <nm127@freemail.hu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Márton Németh authored and Mauro Carvalho Chehab committed Feb 26, 2010
1 parent 6e3924a commit d5abcc7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/media/video/cx231xx/cx231xx-dvb.c
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,9 @@ static int dvb_init(struct cx231xx *dev)
/* define general-purpose callback pointer */
dvb->frontend->callback = cx231xx_tuner_callback;

if (dvb_attach(xc5000_attach, dev->dvb->frontend,
if (!dvb_attach(xc5000_attach, dev->dvb->frontend,
&dev->i2c_bus[1].i2c_adap,
&cnxt_rde250_tunerconfig) < 0) {
&cnxt_rde250_tunerconfig)) {
result = -EINVAL;
goto out_free;
}
Expand All @@ -486,9 +486,9 @@ static int dvb_init(struct cx231xx *dev)
/* define general-purpose callback pointer */
dvb->frontend->callback = cx231xx_tuner_callback;

if (dvb_attach(xc5000_attach, dev->dvb->frontend,
if (!dvb_attach(xc5000_attach, dev->dvb->frontend,
&dev->i2c_bus[1].i2c_adap,
&cnxt_rde250_tunerconfig) < 0) {
&cnxt_rde250_tunerconfig)) {
result = -EINVAL;
goto out_free;
}
Expand Down

0 comments on commit d5abcc7

Please sign in to comment.