Skip to content

Commit

Permalink
V4L/DVB (10341): gspca - stv06xx: Plug a memory leak in the pb0100 se…
Browse files Browse the repository at this point in the history
…nsor driver.

Signed-off-by: Erik Andren <erik.andren@gmail.com>
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Erik Andren authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent 11fb06b commit d5b53f4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
6 changes: 6 additions & 0 deletions drivers/media/video/gspca/stv06xx/stv06xx_pb0100.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,12 @@ static int pb0100_stop(struct sd *sd)
return (err < 0) ? err : 0;
}

static void pb0100_disconnect(struct sd *sd)
{
sd->sensor = NULL;
kfree(sd->sensor_priv);
}

/* FIXME: Sort the init commands out and put them into tables,
this is only for getting the camera to work */
/* FIXME: No error handling for now,
Expand Down
2 changes: 2 additions & 0 deletions drivers/media/video/gspca/stv06xx/stv06xx_pb0100.h
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ static int pb0100_start(struct sd *sd);
static int pb0100_init(struct sd *sd);
static int pb0100_stop(struct sd *sd);
static int pb0100_dump(struct sd *sd);
static void pb0100_disconnect(struct sd *sd);

/* V4L2 controls supported by the driver */
static int pb0100_get_gain(struct gspca_dev *gspca_dev, __s32 *val);
Expand Down Expand Up @@ -142,6 +143,7 @@ const struct stv06xx_sensor stv06xx_sensor_pb0100 = {
.start = pb0100_start,
.stop = pb0100_stop,
.dump = pb0100_dump,
.disconnect = pb0100_disconnect,
};

#endif

0 comments on commit d5b53f4

Please sign in to comment.